[PATCH] D131438: [clang][dataflow] Analyze constructor bodies

[Sam Estep via Phabricator via cfe-commits]

samestep added inline comments.


================
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:224
   // FIXME: Support references here.
-  Env.ReturnLoc = Env.getStorageLocation(*Call, SkipPast::Reference);
+  ReturnLoc = getStorageLocation(*Call, SkipPast::Reference);
 
----------------
ymandel wrote:
> I'd go farther: just duplicate this line in both `pushCalls` and then the two `if` that follow can be moved out as well. at that point, I think `Call` is no longer needed.
Smart! Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131438/new/

https://reviews.llvm.org/D131438