[PATCH] D130933: Add docs for function attributes hot/cold

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 9 13:02:53 PDT 2022


aaron.ballman added a comment.

In D130933#3710682 <https://reviews.llvm.org/D130933#3710682>, @OfekShilon wrote:

> Addressed Aaron's comments (thanks!). Hope I got the update-diff procedure right.

It looks like something might have gone wrong because the diff looks like it's now a diff against something other than the main branch (it looks like it's adding the SimpleHandler lines in Attr.td, but those lines already exist in main).

> I don't have commit permissions, would appreciate if someone could push this.

Once we get the patch fixed up, I'm happy to land on your behalf. What name and email address would you like me to use for patch attribution?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130933/new/

https://reviews.llvm.org/D130933



More information about the cfe-commits mailing list