[PATCH] D122139: [pseudo] Introduce parse forest.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 9 12:50:41 PDT 2022
hokein added inline comments.
================
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Forest.h:158
+ size_t nodeCount() const { return NodeCount; }
+ size_t bytes() const { return Arena.getBytesAllocated() + sizeof(this); }
+
----------------
RKSimon wrote:
> @hokein Static analysis is warning about sizeof(this) - should it be sizeof(*this) ?
Good catch! You're right, it should be `sizeof(*this)`. Fixed in c2c5c39c401b39d2057ebb19b843f53deb950f6e.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122139/new/
https://reviews.llvm.org/D122139
More information about the cfe-commits
mailing list