[PATCH] D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax

[Aman LaChapelle via Phabricator via cfe-commits]

bzcheeseman added a comment.

In D131319#3709671 <https://reviews.llvm.org/D131319#3709671>, @whisperity wrote:

> In D131319#3708667 <https://reviews.llvm.org/D131319#3708667>, @bzcheeseman wrote:
>
>> This is great, thank you for doing this! I'm not a competent reviewer for the actual clang-tidy code changes but the +1 for the idea :)
>
> The problem with the approval here is that a single approval will turn the patch into a fully approved state, which breaks the dashboards for people added to the patch (i.e., other reviewers will think the patch is already approved, and thus perhaps will not consider putting effort into reviewing it!).
>
> However, I think you should try the //Award Token// option from the menu on the right! Somewhere the awarded tokens should show up on the patch, tallying up support!

Ah I had no idea, thanks for pointing that out. I was looking at the Code Review document (https://llvm.org/docs/CodeReview.html), I'll put up a patch to add a short section on this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131319/new/

https://reviews.llvm.org/D131319