[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

[Nico Weber via Phabricator via cfe-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Thanks! LG with comment.



================
Comment at: clang/lib/Driver/Driver.cpp:1638
     llvm::opt::ArgStringList ArgList = NewLLDInvocation.getArguments();
-    ArgList.push_back(Saver.save(Twine{"--reproduce="} + TmpName).data());
+    Twine ReproduceOption =
+        C.getDefaultToolChain().getTriple().isWindowsMSVCEnvironment()
----------------
Twines shouldn't be on the stack. There's no reason for this to be a Twine either -- make it a StringRef (and then cast below if needed)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131214/new/

https://reviews.llvm.org/D131214