[PATCH] D130847: [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of invalid SLockEntry
Ivan Murashko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 9 00:16:34 PDT 2022
ivanmurashko added a comment.
In D130847#3693668 <https://reviews.llvm.org/D130847#3693668>, @aaron.ballman wrote:
> These changes look reasonable, but I verified that the precommit CI failures are valid -- it looks like this change broke a test somehow; perhaps a caller was relying on the old behavior and needs to be reworked?
I fixed the problem. It seems to be reasonable to abort the search procedure at the case of invalid `SLockEntrie`s. That also compatible with existent tests.
I updated the patch title and summary as well.
@aaron.ballman , could you look at it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130847/new/
https://reviews.llvm.org/D130847
More information about the cfe-commits
mailing list