[PATCH] D131466: [clang] add APValue type check in `TryPrintAsStringLiteral`

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 8 22:29:12 PDT 2022


shafik added inline comments.


================
Comment at: clang/lib/AST/APValue.cpp:658
   for (auto &Val : Inits) {
     int64_t Char64 = Val.getInt().getExtValue();
     if (!isASCII(Char64))
----------------
I believe to be fully correct we also need to add:

```
if (!Val.isInt())
  return false;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131466/new/

https://reviews.llvm.org/D131466



More information about the cfe-commits mailing list