[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

[Shafik Yaghmour via Phabricator via cfe-commits]

shafik added inline comments.


================
Comment at: clang/lib/Sema/SemaExprCXX.cpp:5307
     //     T t(create<Args>()...);
+    if (Args.empty())
+      return false;
----------------
I don't believe this is the right fix, the assert below is saying that we should not be here if `Args.empty()` so we are doing something wrong before this point. 

This will prevent the crash but cover up the real issue. 

Unless we have some foundation for saying the assert is not correct but I don't see that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131423/new/

https://reviews.llvm.org/D131423