[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

Kazu Hirata via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 8 21:32:49 PDT 2022


kazu added a comment.

In D131368#3708542 <https://reviews.llvm.org/D131368#3708542>, @dblaikie wrote:

> Sounds good - I'd be probably OK with removing these outright as they're so niche/generally only for use by `llvm::Optional` anyway - but not much harm in keeping them around for the same period the other more visible APIs are deprecated and cleaning it all up together later/then.

Yeah, I was actually sitting on the fence, wondering whether I should just remove them now as they are internal details of `llvm::Optional` as you point out.  I think I'll just remove them in three months or so along with other deprecated methods related to `llvm::Optional`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131368/new/

https://reviews.llvm.org/D131368



More information about the cfe-commits mailing list