[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

Zixuan Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 8 18:42:17 PDT 2022


zixuan-wu added a comment.

In D129824#3706654 <https://reviews.llvm.org/D129824#3706654>, @asb wrote:

> @zixuan-wu we discussed this a bit in the last community sync call <https://discourse.llvm.org/t/risc-v-llvm-sync-up-call-4th-august-2022/64244>. One aspect that makes this patch a little hard to review is the lack of a clear patch description summarising the behaviour before the patch, the behaviour after the patch, and the motivation for the change. I appreciate that the time isn't very convenient in all timezones, but if you were able to attend the next call (18th August, same time) to discuss, that might really help agree a path forwards on this change.

I updated the description. I think it can be understood after see D54214 <https://reviews.llvm.org/D54214>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129824/new/

https://reviews.llvm.org/D129824



More information about the cfe-commits mailing list