[PATCH] D131416: [Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs

[Sergei Barannikov via Phabricator via cfe-commits]

barannikov88 added inline comments.


================
Comment at: clang/include/clang/AST/Expr.h:3832
 
+  llvm::Optional<ICEKind> getICEKind() const { return IK; }
+
----------------
Does it need to be Optional? It seems that it is never checked that it does not hold a value except for the setter method.
An "invalid" enumeration member would serve well IMO.
Not a strong objection.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131416/new/

https://reviews.llvm.org/D131416