[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 8 12:14:10 PDT 2022


efriedma added a comment.

If the declaration we're redeclaring is a builtin, should the diagnostic be in the "-Wincompatible-library-redeclaration" warning group?  With this patch, we treat redefinitions of builtins without a prototype differently from redefinitions with a prototype, for example:

  void acos() {} // error
  void acos(void) {} // warning

Just ran into some code in Android which is using the first form.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123627/new/

https://reviews.llvm.org/D123627



More information about the cfe-commits mailing list