[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

Mon Aug 8 07:56:54 PDT 2022

beanz added a comment.

Since this is adding a new AST node (hopefully the only one we need in HLSL) it would be nice to get @aaron.ballman to take a look here too to make sure this isn't too insane.

================
Comment at: clang/lib/AST/DeclBase.cpp:1191

+  if (getDeclKind() == Decl::HLSLBuffer)
+    return true;
----------------
This could be merged into the return line below, which would make the function easier to understand.

================
Comment at: clang/test/SemaHLSL/cb_error.hlsl:12
+cbuffer;
+
----------------
We should duplicate these cases for `tbuffer`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129883/new/

https://reviews.llvm.org/D129883