[PATCH] D131314: [clang] format string checks for `InitListExpr`

Timm B├Ąder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 6 06:03:47 PDT 2022


tbaeder added a comment.

Not a formal review of course, but for the diagnostics, I'm missing something that tells the user what the format string ended up looking like; in your example, the output never mentions that it checked "%s%d".



================
Comment at: clang/lib/Sema/SemaChecking.cpp:8707
+    if (!HasCStringEnd) {
+      // FIXME: fire a warning that this InitListExprClass does not end with
+      // '\0', with FixIt hints
----------------
I'd prefer not to add more FIXME comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131314/new/

https://reviews.llvm.org/D131314



More information about the cfe-commits mailing list