[PATCH] D131295: [clangd] Implement textDocument/codeLens

[Trass3r via Phabricator via cfe-commits]

Trass3r created this revision.
Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar, mgorny.
Herald added a project: All.
Trass3r edited the summary of this revision.
Trass3r edited projects, added clang-tools-extra; removed All.
Trass3r edited subscribers, added: sammccall; removed: mgorny, javed.absar, arphaman, usaxena95.
Herald added a project: All.
Trass3r added a reviewer: nridge.
Trass3r edited the summary of this revision.
Trass3r added a subscriber: lightmelodies.
Trass3r updated this revision to Diff 450421.
Trass3r added a comment.
Trass3r updated this revision to Diff 450422.
Trass3r published this revision for review.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.

"base" refs are only useful on class forward decls
but for some reasons this still shows up on dtor implementations


Trass3r added a comment.

squashed



================
Comment at: clang-tools-extra/clangd/CodeLens.cpp:86
+    }
+    // bases codelens is only useful on forward decls
+    if (!CXXRD->isThisDeclarationADefinition()) {
----------------
they still show up on dtor implementations iirc


Let's gather some feedback on the code changes for codelens support, they've been rotting since 2 years already.
I started on it back then and it got taken further by @lightmelodies.
Some small issues remain: https://github.com/clangd/clangd/issues/442#issuecomment-1125056812


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131295

Files:
  clang-tools-extra/clangd/CMakeLists.txt
  clang-tools-extra/clangd/ClangdLSPServer.cpp
  clang-tools-extra/clangd/ClangdLSPServer.h
  clang-tools-extra/clangd/ClangdServer.cpp
  clang-tools-extra/clangd/ClangdServer.h
  clang-tools-extra/clangd/CodeLens.cpp
  clang-tools-extra/clangd/CodeLens.h
  clang-tools-extra/clangd/Protocol.cpp
  clang-tools-extra/clangd/Protocol.h
  clang-tools-extra/clangd/TUScheduler.h
  clang-tools-extra/clangd/tool/ClangdMain.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131295.450422.patch
Type: text/x-patch
Size: 19474 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220805/b37a69ff/attachment-0001.bin>