[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

Fri Aug 5 13:34:34 PDT 2022

mstorsjo added a comment.

In D126676#3703024 <https://reviews.llvm.org/D126676#3703024>, @jansvoboda11 wrote:

> Do you think it would make sense to introduce a command-line flag that would control this behavior?

Hmm - I don’t think it’d be necessary. If using the gcc style PCH directory, I would also kinda expect it to be used in a setting where it’s occasionally built with GCC (which requires strict matches) or with a build system that enforces such a setup anyway.

> Also, I'd like to test this patch internally to see if it affects anything on our end. I should be able to do so next week.

Thanks, that’d be very much appreciated!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126676/new/

https://reviews.llvm.org/D126676