[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

Steve Canon via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 5 13:12:12 PDT 2022


scanon added inline comments.


================
Comment at: clang/include/clang/Basic/Builtins.def:1409
 
-LIBBUILTIN(round, "dd", "fnc", "math.h", ALL_LANGUAGES)
-LIBBUILTIN(roundf, "ff", "fnc", "math.h", ALL_LANGUAGES)
-LIBBUILTIN(roundl, "LdLd", "fnc", "math.h", ALL_LANGUAGES)
+LIBBUILTIN(round, "dd", "fng", "math.h", ALL_LANGUAGES)
+LIBBUILTIN(roundf, "ff", "fng", "math.h", ALL_LANGUAGES)
----------------
`round` is just like `trunc` or `floor` or `ceil`, and should be "fnc" if they are.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129231/new/

https://reviews.llvm.org/D129231



More information about the cfe-commits mailing list