[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

Florian Mayer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 5 12:44:22 PDT 2022

fmayer added inline comments.

Comment at: compiler-rt/lib/hwasan/hwasan.cpp:205
+  if (registers_frame && stack->trace && stack->size > 0) {
+    stack->trace++;
+    stack->size--;
fmayer wrote:
> fmayer wrote:
> > vitalybuka wrote:
> > > maybe we should pop everything up to "pc" to avoid issues with nested calls?
> > > 
> > > For most users hwasan frames are not very useful. However if you work on sanitizer, some frames can be a useful info. So I don't mind we just relax test cases to accommodate this nesting.
> > > 
> > > cc @smd 
> > This is probably for another patch though, right? This is already like this on the LHS.
> nevermind. i accidentally had this left, sent https://reviews.llvm.org/D131279 for that.
Sorry, please disregard everything I said here (incl the link). I confused myself where this was posted, and this is all nonsense.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list