[PATCH] D131213: [clang][Headers] Fix unintentional error in D130800
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 5 10:55:48 PDT 2022
aaron.ballman added a comment.
In D131213#3702707 <https://reviews.llvm.org/D131213#3702707>, @iana wrote:
> In D131213#3702699 <https://reviews.llvm.org/D131213#3702699>, @ddcc wrote:
>> I missed line 19, yeah that makes sense. @iana is that ok with you?
> Ah, I didn't see that either. Can we just lose the `defined` on line 26 then? It's redundant and little confusing.
I'm fine dropping it (ever so slightly less work for the preprocessor to do in this file), but I don't see what the confusion is with checking whether `__cplusplus` is defined before testing its value, so I'm also fine with leaving it as-is.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits