[PATCH] D131241: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior.
Vassil Vassilev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 5 00:47:13 PDT 2022
v.g.vassilev added a comment.
Maybe we can add a little more context. In the case of static compilation the file system is pretty much read-only and taking a snapshot of it usually is sufficient. In the interactive C++ case the compilation is longer and people can create and include files, etc. In that case we often do not want to open files or cache failures unless is absolutely necessary. We might be able to write a test for this in `clang/unittests/Lex/HeaderSearchTest.cpp`. However, this patch improves consistency in the interfaces by forwarding the already provided flags to the callees and if we cannot write a reasonable test we should be able to accept it without.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits