[PATCH] D130907: [Clang] Use pragma FENV_ROUND to reset rounding mode settings.
Eli Friedman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 4 11:40:33 PDT 2022
efriedma added inline comments.
================
Comment at: clang/lib/Sema/SemaStmt.cpp:398
+ // If dynamic rounding mode is specified in absence of FENV_ACCESS, treat it
+ // as setting default rounding mode.
+ FpPragmaStack.CurrentValue.clearConstRoundingModeOverride();
----------------
I'm not really happy with the way this is written... like I mentioned in the other patch, keep the state transitions simple, and put the logic into the code that computes the derived properties.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130907/new/
https://reviews.llvm.org/D130907
More information about the cfe-commits
mailing list