[PATCH] D124751: [HLSL] Support -E option for HLSL.

[Chris Bieneman via Phabricator via cfe-commits]

beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

One very nitpick-y comment, otherwise LGTM.



================
Comment at: clang/lib/Sema/SemaDecl.cpp:9841
+    if (!NewFD->isInvalidDecl() &&
+        // Skip operator overload which not identifier.
+        Name.isIdentifier() &&
----------------
nit: Comments in the middle of the if make it a bit hard to read, and is not a common style in LLVM code. Please put the comments above the if describing the condition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124751/new/

https://reviews.llvm.org/D124751