[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 4 06:14:36 PDT 2022


aaron.ballman added a comment.

In D130906#3699342 <https://reviews.llvm.org/D130906#3699342>, @inclyc wrote:

> In D130906#3699335 <https://reviews.llvm.org/D130906#3699335>, @aaron.ballman wrote:
>
>> In D130906#3699323 <https://reviews.llvm.org/D130906#3699323>, @inclyc wrote:
>>
>>> Thank you!  I already have the commit access, I can commit this myself ^_^
>>
>> Excellent! Feel free to land when you're ready. :-)
>
> Sorry I haven't noticed this yet, should I revert changes and commit again?

No worries! And no need to revert; you can land an NFC change that switches the `auto` to `Expr` (no need for a review).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130906/new/

https://reviews.llvm.org/D130906



More information about the cfe-commits mailing list