[PATCH] D131006: [analyzer] Use DisequalityMap while inferring constraints

[Gabor Marton via Phabricator via cfe-commits]

martong added inline comments.


================
Comment at: clang/test/Analysis/range-inferring-from-disequality-map.cpp:10-11
+     clang_analyzer_value(x); // expected-warning {{32s:{ [0, 0] }}}
+  // TODO:  TODO: Keep x range correct even if associated disequalities are
+  // already dead.
+  (void)tmp; // Keep alive.
----------------
martong wrote:
> Good point.
> 
> We should have an additional check in `removeDeadBindings` that goes through the disequality map of the dead symbol. And if any of the mapped classes are not dead then we shall not delete the dead symbol's equivalent class.
> Good point.
> 
> We should have an additional check in `removeDeadBindings` that goes through the disequality map of the dead symbol. And if any of the mapped classes are not dead then we shall not delete the dead symbol's equivalent class.

It would be better to address that in a child patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131006/new/

https://reviews.llvm.org/D131006