[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

[Fangrui Song via Phabricator via cfe-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6350
 
+  if (Args.hasArg(options::OPT_mindirect_branch_cs_prefix))
+    CmdArgs.push_back("-mindirect-branch-cs-prefix");
----------------
pengfei wrote:
> MaskRay wrote:
> > This is not needed with the TableGen CC1Option change.
> Do you have an example how to change the CC1Option? Removing the code directly won't generate the expected module flag anymore.
OK, sorry. A statement is needed: `Args.AddLastArg(CmdArgs, options::OPT_mindirect_branch_cs_prefix); `


================
Comment at: clang/test/Driver/x86_features.c:15
+
+// RUN: %clang -target i386-unknown-unknown -### %s -mindirect-branch-cs-prefix -S 2>&1 | FileCheck --check-prefix=IND-CS %s
+// IND-CS: "-mindirect-branch-cs-prefix"
----------------
Use `--target=i386` instead of legacy `-target `


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130754/new/

https://reviews.llvm.org/D130754