[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

Tom Stellard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 3 14:21:00 PDT 2022


tstellar added inline comments.


================
Comment at: clang/CMakeLists.txt:21-23
+  set(INCLUDE_DIRS "${LLVM_BINARY_DIR}/include" "${MAIN_INCLUDE_DIR}")
+  # Pull values from LLVMConfig.cmake.
+  set(MAIN_INCLUDE_DIR "${LLVM_INCLUDE_DIR}")
----------------
This doesn't look right (even though it passes my testing).  I need to update this part of the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128777/new/

https://reviews.llvm.org/D128777



More information about the cfe-commits mailing list