[PATCH] D130516: [llvm] compression classes
Cole Kissane via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 3 11:20:05 PDT 2022
ckissane added inline comments.
================
Comment at: llvm/include/llvm/Support/Compression.h:48-51
+ Error decompress(ArrayRef<uint8_t> Input, uint8_t *UncompressedBuffer,
+ size_t &UncompressedSize) {
+ return Decompress(Input, UncompressedBuffer, UncompressedSize);
+ }
----------------
dblaikie wrote:
> Could we skip this wrapper & just have the underlying function (& also we shouldn't be overloading by case like this anyway - please name all the decompress/compress functions with the same case/spelling)
good point
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130516/new/
https://reviews.llvm.org/D130516
More information about the cfe-commits
mailing list