[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9060
         continue;
-      const VarDecl *VD = LC.getCapturedVar();
+      const VarDecl *VD = cast<VarDecl>(LC.getCapturedVar());
       if (LC.getCaptureKind() != LCK_ByRef && !VD->getType()->isPointerType())
----------------
aaron.ballman wrote:
> aaron.ballman wrote:
> > cor3ntin wrote:
> > > cor3ntin wrote:
> > > > I'm not sure we currently prohibit capturing a structured binding in openmp, i should fix that
> > > I disabled the feature in OpenMP mode, as this needs more investigation
> > Ping @jdoerfert -- do you happen to know what's up here?
> Ping @mikerice or @ABataev in case @jdoerfert is on vacation.
> 
> (Note, I don't think an answer to this question is needed to accept this review.)
Need to support capturing of structured bindings in OpenMP regions, some people asked for it long time ago.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122768/new/

https://reviews.llvm.org/D122768