[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM once nits are fixed (take or leave them).



================
Comment at: clang/lib/Basic/IdentifierTable.cpp:169
+  case KEYALTIVEC:
+    return LangOpts.AltiVec ? KS_Enabled : KS_Unknown;
+  case KEYBORLAND:
----------------
erichkeane wrote:
> aaron.ballman wrote:
> > Should this one be "extension" instead?
> It was not before, and the intent is for this to be NFC:
> 
> `  if (LangOpts.AltiVec && (Flags & KEYALTIVEC)) return KS_Enabled;`
> 
> I'm not sure the logic that was applied though.  The only difference seems to be whether we emit a 'extension used' diagnostic.
Okay, given that the goal of this is NFC, I'm happy enough.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131007/new/

https://reviews.llvm.org/D131007