[PATCH] D131012: No longer place const volatile global variables in a read only section

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 2 13:24:39 PDT 2022

aaron.ballman added a comment.

In D131012#3694502 <https://reviews.llvm.org/D131012#3694502>, @rjmccall wrote:

> I think this is fine for the ABI; the section is generally a definition-specific property and doesn't affect use sites.
> Do we also need to check for volatile fields of records?

GCC doesn't seem to do anything special there as best I can tell: https://godbolt.org/z/67eovqoG8

In D131012#3694588 <https://reviews.llvm.org/D131012#3694588>, @nickdesaulniers wrote:

> Thanks for the patch. I've asked some of my colleagues who work on libabigail their thoughts on the implications of this change.  Due to timezones, it may take some time to hear back.  Mind holding this for 24hr and I'll update this with the feedback, if any?

Happy to wait!

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list