[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

Tue Aug 2 13:22:56 PDT 2022

abrachet added a comment.

In D120175#3693458 <https://reviews.llvm.org/D120175#3693458>, @probinson wrote:

> There is now cross-project-tests which would seem to be the appropriate place for a test that wants to run both clang and lld.

Thanks for pointing that out. I'll look into moving the test there

================
Comment at: clang/lib/Driver/Driver.cpp:1638
+    llvm::opt::ArgStringList ArgList = NewLLDInvocation.getArguments();
+    ArgList.push_back(Saver.save(Twine{"--reproduce="} + TmpName).data());
+    NewLLDInvocation.replaceArguments(std::move(ArgList));
----------------
thakis wrote:
> This does the wrong thing on Windows, I think (the flag is spelled /reproduce:path there I think?)
Ah yeah good catch. Unfortunately this wasn't caught upstream because I quickly had to change to explicit target because *-ps4 target doesn't support `-fuse-ld` and there didn't already exist a PS4 lit feature that I could mark as unsupported. This was actually why you saw test failures on non linux platforms.

I'll make a new review that correctly uses `/reproduce:`. Thanks again

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120175/new/

https://reviews.llvm.org/D120175