[PATCH] D131004: [clang] Add FileEntryRef::getNameAsRequested()
Ben Barham via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 2 12:37:07 PDT 2022
bnbarham accepted this revision.
bnbarham added a comment.
This revision is now accepted and ready to land.
Thanks 🙇
================
Comment at: clang/unittests/Basic/FileManagerTest.cpp:381
EXPECT_TRUE(F1->isSameRef(*F1Again));
- EXPECT_TRUE(F1->isSameRef(*F1Redirect));
+ EXPECT_FALSE(F1->isSameRef(*F1Redirect));
EXPECT_FALSE(F1->isSameRef(*F1Also));
----------------
Bit weird that this test was checking for true 🤔. Seems like it isn't used outside of tests except for `isEqual` in `DenseMapInfo` though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131004/new/
https://reviews.llvm.org/D131004
More information about the cfe-commits
mailing list