[PATCH] D130516: [llvm] compression classes

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 2 12:32:33 PDT 2022


dblaikie added a comment.

> I think I have worked out something that is the best of both worlds:

I think @MaskRay's main concern, which I share to a degree, is that there's a lot of code/complexity here that doesn't currently seem warranted by the size of the problem. So adding more implementation complexity to this patch, even if it does provide some of the benefits (though I don't think the ability to do boolean logic, etc, is the main concern either myself or @maskray have - either way we'll have the enum) it's adding a lot more implementation complexity, which is something we're trying to address/reduce.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130516/new/

https://reviews.llvm.org/D130516



More information about the cfe-commits mailing list