[PATCH] D130791: [clang] Short-circuit trivial constexpr array constructors
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 2 09:56:22 PDT 2022
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! I agree that test coverage for the performance issue is basically impossible with our testing system. I was thinking "well good, add a test with a huge initializer to make sure it doesn't crash" but then I realized that will slow down running the tests significantly and will always be susceptible to a slightly larger array than the test uses being a problem. So I think it's fine to land this without tests.
CHANGES SINCE LAST ACTION
More information about the cfe-commits