[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

Ivan Murashko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 2 08:41:25 PDT 2022


ivanmurashko added a comment.

In D130847#3693668 <https://reviews.llvm.org/D130847#3693668>, @aaron.ballman wrote:

> These changes look reasonable, but I verified that the precommit CI failures are valid -- it looks like this change broke a test somehow; perhaps a caller was relying on the old behavior and needs to be reworked?

Ah, I have to verify and fix it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130847/new/

https://reviews.llvm.org/D130847



More information about the cfe-commits mailing list