[PATCH] D130863: [clangd] Make git ignore index directories

Tue Aug 2 05:34:08 PDT 2022

ilya-biryukov added a comment.

In D130863#3693293 <https://reviews.llvm.org/D130863#3693293>, @sammccall wrote:

> In D130863#3693135 <https://reviews.llvm.org/D130863#3693135>, @ilya-biryukov wrote:
>
>> Otherwise, I would personally still put `.cache/clangd` into the global `.gitignore` or `.git/info/exclude`. IMO `.cache/clangd` should not be in the VCS history at all, even if only for the `.gitignore` files.
>> So landing this as is wouldn't really improve the situation for me personally.
>
> Oh, i was under the impression that git didn't track empty directories and this was recursive: if .cache/clangd/index/* are ignored then index/ doesn't exist, so nor does clangd/ or .cache/.
>
> If this is not the case i agree the value is less... (Can't check, don't have a real computer this week)

No, you're right. I was mistaken about what the patch is doing.
Forget what I said, this change is fine. No `.gitignore` files are in the `git status` output.

I'm still think that I need to ignore files for other tools I use anyway, so not doing this for clangd is not a big improvement.
But that's just my opinion, please disregard other concerns.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130863/new/

https://reviews.llvm.org/D130863