[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 2 02:17:45 PDT 2022

LiuChen3 added a comment.

In D124435#3515541 <https://reviews.llvm.org/D124435#3515541>, @jyknight wrote:

> I find the option names you have a bit confusing. I'd like to suggest calling them, instead:
> caller: Extend a small integer parameter in the caller; callee will assume it has already been extended.
> callee : Pass a small integer parameter directly in caller, extend in callee when converting to full-width.
> both: Extend a small integer parameter in the caller; callee ALSO extends when converting to full-width.
> default: Use the default rule for the target.
> I think that gets more to the point of what's going on here, even though it's not exactly the case that "callee" always extends.

rjmccall's comment convinced me.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list