[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

Alex Bradbury via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 2 01:40:16 PDT 2022


asb added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:232
+bool RISCVISAInfo::hasVInstructions() const {
+  return hasExtension("zve32x");
+}
----------------
Given the other sub-thread showed that hasExtennsion("zve32x") == hasVInstructions isn't completely obvious, perhaps worth a comment like "zve32x is the root of the V extension inheritance tree. i.e. enabling any of the vector extensions will implicitly enable zve32x."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130311/new/

https://reviews.llvm.org/D130311



More information about the cfe-commits mailing list