[PATCH] D130934: [clang] Update code that assumes FileEntry::getName is absolute NFC
Ben Langmuir via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 1 13:32:13 PDT 2022
benlangmuir created this revision.
benlangmuir added reviewers: bnbarham, jansvoboda11.
Herald added a project: All.
benlangmuir requested review of this revision.
Herald added projects: clang, clang-tools-extra.
Herald added a subscriber: cfe-commits.
It's an accident that we started return asbolute paths from FileEntry::getName for all relative paths. Prepare for getName to get (closer to) return the requested path. Note: conceptually it might make sense for the dependency scanner to allow relative paths and have the DependencyConsumer decide if it wants to make them absolute, but we currently document that it's absolute and I didn't want to change behaviour here.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D130934
Files:
clang-tools-extra/clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp
clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp
clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130934.449111.patch
Type: text/x-patch
Size: 7254 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220801/258fd2ee/attachment.bin>
More information about the cfe-commits
mailing list