[PATCH] D130918: [clang][ExtractAPI] Record availability information on all platforms

Zixu Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 1 11:24:10 PDT 2022


zixuw added a comment.

Thanks Daniel!



================
Comment at: clang/test/ExtractAPI/availability.c:16
+//--- input.h
+/// Documentation for a.
+void a(void);
----------------
Do we care about doc comments for this particular test?
The testing convention for all the ExtractAPI tests is probably not the most ideal one because every test is a complete matching of the full Symbol Graph output.
So if we try to limit the scope of this test to just availability attributes it would be easier to read, and also avoid potential irrelevant failures in this test if something should broke the doc comment part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130918/new/

https://reviews.llvm.org/D130918



More information about the cfe-commits mailing list