[PATCH] D130827: [clang] Fixed a number of typos

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 1 10:17:22 PDT 2022

aaron.ballman added a comment.

In D130827#3691371 <https://reviews.llvm.org/D130827#3691371>, @GabrielRavier wrote:

>> Do you need someone to land this on your behalf?
> I assume so since landing seems to mean pushing the commit to the repo which I'm pretty sure I don't have the rights to do.

Okie dokie! I try to double-check with anyone who I'm not used to seeing commits from.

>> If so, what name and email address would you like used for patch attribution?
> `Gabriel Ravier`, `gabravier at gmail.com`
> (By the way, is there any way to make this information part of my Phabricator account so that I don't need to repeat this every time I submit a patch ? The patch I made for `clang-tools-extra` got in with the right name/email pair just fine without me having to say anything, so I was assuming it was there somewhere...)

Thank you! I've gone ahead and landed the changes. I don't think there's a way to add the information to Phab in a way that all the code reviewers will notice. Some reviewers will land based on whatever email address you are using for Phabricator, others ask explicitly, some others will go look at prior reviews to see if they can find the info without asking, etc. FWIW, after you have a few patched submitted on your behalf, we'll often ask if you'd like to obtain commit privileges of your own (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access).

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list