[PATCH] D130636: [clangd] Upgrade vlog() to log() for preamble build stats

[Adam Czachorowski via Phabricator via cfe-commits]

adamcz added inline comments.


================
Comment at: clang-tools-extra/clangd/Preamble.cpp:555
   if (BuiltPreamble) {
-    vlog("Built preamble of size {0} for file {1} version {2} in {3} seconds",
+    log("Built preamble of size {0} for file {1} version {2} in {3} seconds",
          BuiltPreamble->getSize(), FileName, Inputs.Version,
----------------
kadircet wrote:
> what about also moving this log into TUScheduler.cpp::reportPreamble, in which we can also log whether this is a "first preamble" or not?
I considered that, but this isn't structured log or something you'd process automatically and it's already clear from context in that log file if it's first build or rebuild. I think it's simpler to keep the log line here, to match the error line below.

If you have a use case for this information let me know and I'll update this change, otherwise I'll just go with the simple solution.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130636/new/

https://reviews.llvm.org/D130636