[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

[krishna chaitanya sankisa via Phabricator via cfe-commits]

skc7 added a comment.

In D130224#3688067 <https://reviews.llvm.org/D130224#3688067>, @amyk wrote:

> In D130224#3688034 <https://reviews.llvm.org/D130224#3688034>, @skc7 wrote:
>
>> In D130224#3687907 <https://reviews.llvm.org/D130224#3687907>, @aaron.ballman wrote:
>>
>>> In D130224#3687860 <https://reviews.llvm.org/D130224#3687860>, @amyk wrote:
>>>
>>>> In D130224#3687487 <https://reviews.llvm.org/D130224#3687487>, @mubarizafzal wrote:
>>>>
>>>>> Hi, the test cases that this patch introduces are failing on some ppc64le (Linux on Power) buildbots:
>>>>> https://lab.llvm.org/buildbot/#/builders/57
>>>>> https://lab.llvm.org/buildbot/#/builders/230
>>>>> Would you mind taking a look please?
>>>>
>>>> Thanks for pinging this patch. It appears it's affecting both little endian PPC:
>>>> https://lab.llvm.org/buildbot/#/builders/230/builds/1079
>>>> https://lab.llvm.org/buildbot/#/builders/121/builds/21978
>>>> https://lab.llvm.org/buildbot/#/builders/57/builds/20484
>>>> https://lab.llvm.org/buildbot/#/builders/36/builds/23702
>>>>
>>>> And big endian PPC bots:
>>>> https://lab.llvm.org/buildbot/#/builders/231/builds/842
>>>> https://lab.llvm.org/buildbot/#/builders/93/builds/10270
>>>
>>> If we don't hear from @skc7 in the next ~hour with a fix, feel free to revert to get the bots back to green.
>>
>> Issue is with missing target triple in the tests. Submitted D130790 <https://reviews.llvm.org/D130790> for review, which should fix the tests.
>
> I realized I didn't happen to see this comment in time and had already reverted the patch. My apologies on this.

Relanded the revert with fixes to tests. commit <https://github.com/llvm/llvm-project/commit/09c41211231578765cdb296bda3b4c7f3c22b4ba>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130224/new/

https://reviews.llvm.org/D130224