[PATCH] D130827: [clang] Fixed a number of typos

Gabriel Ravier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 31 07:40:29 PDT 2022


GabrielRavier added inline comments.


================
Comment at: clang/include/clang/Sema/Sema.h:4022
+      ExprResult &SrcExpr, bool DoFunctionPointerConversion = false,
+      bool Complain = false, SourceRange OpRangeForComplaining = SourceRange(),
+      QualType DestTypeForComplaining = QualType(),
----------------
junaire wrote:
> GabrielRavier wrote:
> > junaire wrote:
> > > Normally we don't clang-format legacy code like this, as it's bad for git blame. 
> > I've undone the clang-formatting on this
> Oh, I'm sorry about it I think I missed something here. So basically if you touched the code then format it is a good choice. I thought there was nothing changed here but only formatting, that's something we usually want to avoid. 
I've un-undone the clang-formatting on this


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130827/new/

https://reviews.llvm.org/D130827



More information about the cfe-commits mailing list