[PATCH] D130422: [clang-repl] Fix incorrect return code
Vassil Vassilev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jul 31 01:10:49 PDT 2022
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
Thanks for working on this. This is one of the problems where is hard to find the right behavior. For example, if a repl running in interactive issues an error and then successfully recovers what's the right process return code success or a failure? If we decide it is a success then if we ran in non-interactive mode eg `clang-repl "err"` then the exit code should be a failure.
Either way, this patch improves our current state in which we cannot detect failing tests in `-verify` mode. Let's accept it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130422/new/
https://reviews.llvm.org/D130422
More information about the cfe-commits
mailing list