[PATCH] D128158: [AMDGPU] Add amdgcn_sched_group_barrier builtin

Sat Jul 30 07:48:15 PDT 2022

kerbowa marked an inline comment as done.
kerbowa added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:314
+
+bool SchedGroup::isFull() const {
+  return MaxSize && Collection.size() >= *MaxSize;
----------------
uabelho wrote:
> Compiling with gcc, I get a warning that this function is unused.
> I'm wondering, there seems to be both a const and a non-const version of the isFull method now, but they are identical? Perhaps the non-const version could be removed?
Removed in 7898426a72, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128158/new/

https://reviews.llvm.org/D128158