[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

Fri Jul 29 13:45:59 PDT 2022

vsapsai marked 2 inline comments as done.
vsapsai added inline comments.

================
Comment at: clang/lib/Serialization/ASTReader.cpp:9193-9195
-  // Otherwise, use the name of the top-level module the decl is within.
-  if (ModuleFile *M = getOwningModuleFile(D))
-    return M->ModuleName;
----------------
At first I though this part was important for certain tests. But I guess I've messed up somewhere else.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128490/new/

https://reviews.llvm.org/D128490