[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo updated this revision to Diff 448708.
mstorsjo added a comment.

Update the parameters to the internal `checkPreprocessorOptions` function to use a three-state enum instead of having two separate `bool` flags.

The 15.x release already has been branched, but I'd like to have this backported and included if possible (the regression risk should be quite small as long as it's restricted to GCC PCH directories). To handle that, I'd omit the release notes when pushing to the main branch (as the release notes document differs between the branches) and manually add that to the release branch, if this is accepted for backport.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126676/new/

https://reviews.llvm.org/D126676

Files:
  clang/docs/ReleaseNotes.rst
  clang/include/clang/Serialization/ASTReader.h
  clang/lib/Frontend/FrontendAction.cpp
  clang/lib/Serialization/ASTReader.cpp
  clang/test/PCH/pch-dir.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126676.448708.patch
Type: text/x-patch
Size: 12043 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220729/26792e85/attachment-0001.bin>