[PATCH] D130614: [C++20] [Modules] Merge same concept decls in global module fragment
Chuanqi Xu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 28 19:46:04 PDT 2022
ChuanqiXu added a comment.
In D130614#3685142 <https://reviews.llvm.org/D130614#3685142>, @ilya-biryukov wrote:
> Thanks for the thorough explanation and testing.
> LGTM.
Thanks for reviewing!
================
Comment at: clang/lib/Sema/SemaDecl.cpp:1747
+
+ Module *NewM = New->getOwningModule();
+ Module *OldM = Old->getOwningModule();
----------------
ilya-biryukov wrote:
> NIT: maybe accept the modules directly?
I feel like the current style saves more typing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130614/new/
https://reviews.llvm.org/D130614
More information about the cfe-commits
mailing list