[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

[Xiang Li via Phabricator via cfe-commits]

python3kgae marked an inline comment as done.
python3kgae added inline comments.


================
Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:142
+      if (!Inner) {
+        DiagnosticsEngine &Diags = CGM.getDiags();
+        unsigned DiagID = Diags.getCustomDiagID(DiagnosticsEngine::Error,
----------------
beanz wrote:
> python3kgae wrote:
> > python3kgae wrote:
> > > Anastasia wrote:
> > > > Is this case covered by the test?
> > > Nice catch.
> > > I'll add a test for this.
> > Cannot add a test before other HLSL resource type like Texture2D is supported :(
> `Texture2D` will be a `CXXRecordDecl`, not a `HLSLBufferDecl`, we only need buffer decls for the legacy buffers. So this should be testable by nesting a cbuffer inside a cbuffer right?
I see.
I was thinking about test the error path.
I'll add a test for nested cbuffer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130131/new/

https://reviews.llvm.org/D130131